Sourcery refactored main branch #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Comment on lines
-29
to
+30
| def as_manager(cls): | ||
| manager = TenantAwareManager.from_queryset(cls)() | ||
| def as_manager(self): | ||
| manager = TenantAwareManager.from_queryset(self)() |
There was a problem hiding this comment.
Function TenantAwareQuerySet.as_manager refactored with the following changes:
- The first argument to instance methods should be
self(instance-method-first-arg-name)
| return match.groups() | ||
| elif (match := re.search(r'/(.*)', path)): | ||
| if (tenant := match.group(1)): | ||
| if tenant := match[1]: |
There was a problem hiding this comment.
Function split_tenant refactored with the following changes:
- Replace m.group(x) with m[x] for re.Match objects (
use-getitem-for-re-match-groups)
Comment on lines
-25
to
+29
| if not hasattr(settings, 'TENANTS_EXEMPT'): | ||
| return False | ||
| return tenant_name in settings.TENANTS_EXEMPT | ||
| return ( | ||
| tenant_name in settings.TENANTS_EXEMPT | ||
| if hasattr(settings, 'TENANTS_EXEMPT') | ||
| else False | ||
| ) |
There was a problem hiding this comment.
Function tenant_exempt refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp) - Swap if/else branches of if expression to remove negation (
swap-if-expression)
Comment on lines
15
to
16
| if model_name == 'tenant' and db != 'default': | ||
| return False | ||
| return None No newline at end of file | ||
| return False if model_name == 'tenant' and db != 'default' else None No newline at end of file |
There was a problem hiding this comment.
Function TenantRouter.allow_migrate refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp)
| setattr(THREAD_LOCAL, "DB", db) | ||
| response = self.get_response(request) | ||
| return response | ||
| return self.get_response(request) |
There was a problem hiding this comment.
Function TenantMiddleware.__call__ refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
| @pytest.mark.django_db | ||
| def test_ok(): | ||
| baker.make('core.User') | ||
| assert True |
There was a problem hiding this comment.
Function test_ok refactored with the following changes:
- Remove
assert Truestatements (remove-assert-true)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
mainrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
mainbranch, then run:Help us improve this pull request!