Skip to content

Conversation

@PeterDaveHello
Copy link
Contributor

Not sure if it's the correct way to do so, I hope it works 🎉

@GyulyVGC GyulyVGC added the translation User interface translation label Apr 11, 2025
@GyulyVGC GyulyVGC added this to the v1.4.0 milestone Apr 11, 2025
@GyulyVGC
Copy link
Owner

Thanks 🙏
I'll review your PR as soon as I get some spare time!

@GyulyVGC
Copy link
Owner

GyulyVGC commented Apr 13, 2025

I was curious to understand the origin of this language and found out on Wikipedia that the ZH_TW language code can have different meanings.

Could you clarify what's your translation referring to?

Is it correct to refer to your translation simply as "Traditional Chinese"? It seems like it's only specific to Taiwan instead.

@FishOrBear
Copy link

I was curious to understand the origin of this language and found out on Wikipedia that the ZH_TW language code can have different meanings.

Could you clarify what's your translation referring to?

Is it correct to refer to your translation simply as "Traditional Chinese"? It seems like it's only specific to Taiwan instead.

Traditional Chinese is correct. Traditional Chinese is not only used in Taiwan. In fact, it is also used in Hong Kong, Taiwan, and other places.

@FishOrBear
Copy link

However, Traditional Chinese in Taiwan may have different representation methods.

@FishOrBear
Copy link

FishOrBear commented Apr 14, 2025

Traditional Chinese (Taiwan)
繁體中文(台灣)

@PeterDaveHello
Copy link
Contributor Author

Yes, this is Traditional Chinese. Of course, it’s fine to include a note in parentheses mentioning that it also applies to Taiwan, as Taiwan is the largest and most significant market for Traditional Chinese users. Also, my usage leans toward Taiwan’s conventions.

@PeterDaveHello
Copy link
Contributor Author

I just resolved those merge conflicts, and I'm looking forward to not having them again 😆

@GyulyVGC
Copy link
Owner

Thank you 🙏

@GyulyVGC
Copy link
Owner

GyulyVGC commented Apr 14, 2025

Hey @PeterDaveHello I need you to enable me push to your fork.

I have 3 commits pending.

@GyulyVGC
Copy link
Owner

There should be a button like this in the GitHub interface of this PR.

image

@PeterDaveHello
Copy link
Contributor Author

@GyulyVGC because I sent it from my working space organization, so there's no such button 😅 However, I invited you to join the project with the write permission. Hopefully, it'll be good enough to allow your edits!

@GyulyVGC
Copy link
Owner

It worked, thanks 👍

@GyulyVGC
Copy link
Owner

@all-contributors please add @PeterDaveHello for translation.

@allcontributors
Copy link
Contributor

@GyulyVGC

I've put up a pull request to add @PeterDaveHello! 🎉

@GyulyVGC GyulyVGC merged commit 3ad8e65 into GyulyVGC:main Apr 15, 2025
3 checks passed
@PeterDaveHello PeterDaveHello deleted the ZH_TW branch April 15, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translation User interface translation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants