Skip to content

Add icon to window title bar #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 16, 2025
Merged

Add icon to window title bar #719

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
253da11
fix #715
GyulyVGC Feb 16, 2025
ff81548
update CHANGELOG
GyulyVGC Feb 16, 2025
39b3ac4
include icon file in crate.io package
GyulyVGC Feb 16, 2025
88da289
use winres to set application icon on Windows
GyulyVGC Feb 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ All Sniffnet releases with the relative changes are documented in this file.
- Ukrainian ([#692](https://github.com/GyulyVGC/sniffnet/pull/692))
- Added new themes _OLED (Night)_ and _OLED (Day)_ based on palettes optimized for OLED displays and users with visual impairments ([#708](https://github.com/GyulyVGC/sniffnet/pull/708))
- Fix _crates.io_ package for Windows ([#718](https://github.com/GyulyVGC/sniffnet/pull/718) — fixes [#681](https://github.com/GyulyVGC/sniffnet/issues/681))
- Add icon to window title bar ([#719](https://github.com/GyulyVGC/sniffnet/pull/719) — fixes [#715](https://github.com/GyulyVGC/sniffnet/issues/715))

## [1.3.2] - 2025-01-06
- Dropdown menus for network host filters ([#659](https://github.com/GyulyVGC/sniffnet/pull/659) — fixes [#354](https://github.com/GyulyVGC/sniffnet/issues/354))
Expand Down
95 changes: 95 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ include = [
"/resources/countries_flags/**/*.svg",
"/resources/DB/*.mmdb",
"/resources/fonts/subset/*.ttf",
"/resources/logos/raw/icon.png",
"/resources/sounds/*.mp3",
"/services.txt",
"/build.rs",
Expand All @@ -39,7 +40,7 @@ pcap = "2.2.0"
etherparse = "0.17.0"
chrono = { version = "0.4.39", default-features = false, features = ["clock"] }
plotters = { version = "0.3.7", default-features = false, features = ["area_series"] }
iced = { version = "0.13.1", features = ["tokio", "svg", "advanced", "lazy"] }
iced = { version = "0.13.1", features = ["tokio", "svg", "advanced", "lazy", "image"] }
plotters-iced = "0.11.0"
maxminddb = "0.24.0"
confy = "0.6.1"
Expand Down
5 changes: 4 additions & 1 deletion src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ use std::borrow::Cow;
use std::sync::{Arc, Mutex};
use std::{panic, process, thread};

use iced::advanced::graphics::image::image_rs::ImageFormat;
#[cfg(target_os = "linux")]
use iced::window::settings::PlatformSpecific;
use iced::{application, window, Font, Pixels, Settings};
Expand Down Expand Up @@ -51,6 +52,8 @@ mod utils;
pub const SNIFFNET_LOWERCASE: &str = "sniffnet";
pub const SNIFFNET_TITLECASE: &str = "Sniffnet";

const WINDOW_ICON: &[u8] = include_bytes!("../resources/logos/raw/icon.png");

/// Entry point of application execution
///
/// It initializes shared variables and loads configuration parameters
Expand Down Expand Up @@ -122,7 +125,7 @@ pub fn main() -> iced::Result {
resizable: true,
decorations: true,
transparent: false,
icon: None,
icon: window::icon::from_file_data(WINDOW_ICON, Some(ImageFormat::Png)).ok(),
#[cfg(target_os = "linux")]
platform_specific: PlatformSpecific {
application_id: String::from(SNIFFNET_LOWERCASE),
Expand Down