Added type guessing from data / see #99 #100
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't see anything wrong in StyleCI, but it failed. Is there something to correct? |
|
Just see the diff: https://styleci.io/analyses/qoj3BX You have trailing white-spaces and a missing dot on comment. |
| @@ -23,4 +23,22 @@ public function getInfos() | |||
| { | |||
| return sha1($this->data); | |||
| } | |||
|
|
|||
| public function guessType() | |||
There was a problem hiding this comment.
Need a PHP doc block.
|
Will this get merged soon? |
|
Hello, can you fix the conflicts ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the #99 issue.
There was no guessing from Source\Data. It always returned "jpeg".