Skip to content

Conversation

@linuspahl
Copy link
Contributor

@linuspahl linuspahl commented Jan 20, 2026

Description

Motivation and Context

This PR contains required changes for https://github.com/Graylog2/graylog-plugin-enterprise/pull/12956

/nocl - part of enterprise PR
/prd https://github.com/Graylog2/graylog-plugin-enterprise/pull/12956

@linuspahl linuspahl marked this pull request as ready for review January 20, 2026 13:54
@linuspahl linuspahl requested review from a team, dennisoelkers and maxiadlovskii January 20, 2026 14:00
@linuspahl linuspahl added the e2e-tests Run PR build with e2e tests. label Jan 20, 2026
Copy link
Contributor

@ryan-carroll-graylog ryan-carroll-graylog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM aside from the failing back end test. Thanks Linus!


@DbEntity(collection = COLLECTION_NAME,
titleField = USERNAME,
titleField = FULL_NAME,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably the most important change i this PR. I made this change to use the full name as a title for the response of /system/catalog/entities/titles.

This unifies the display name with other case like the event owner assign modal.
Ideally display a combination of full name + user name everywhere, to ensure uniqueness, but that is out of the scope of this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed that this comment was still "pending".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e-tests Run PR build with e2e tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants