Skip to content

Conversation

etwest
Copy link
Collaborator

@etwest etwest commented Oct 18, 2023

This pull request refactors the key classes of this repository with the goal of increasing the flexibility of our code. We want to allow the possibly for writing code for other sketching algorithms on top of this repository. Specifically, we disentangled the setup for reading and processing graph streams from the code for running the connected components sketch algorithm. We also got rid of the Supernode class and refactored the sketch class to be more usable.

Also some other small stuff, see below.

  • Config for driver and cc algorithm seperately
  • Extract spanning forest edges option for CCSketchAlg
  • Sketch constructor using vector length rather than number of vertices. Add static vec_len_from_verts().
  • Graph destructor
  • Raw bucket delta update
  • Exaustive sample
  • Investigate query performance
  • More testing
  • Rename graph_test.cpp to cc_alg_test.cpp
  • See comments below

@etwest etwest requested a review from DanielDeLayo October 18, 2023 20:28
@DanielDeLayo
Copy link
Contributor

We need to change the sketch interface. Let us input the vector length, instead of the square root of the vector length.

DanielDeLayo
DanielDeLayo previously approved these changes Oct 23, 2023
Copy link
Contributor

@DanielDeLayo DanielDeLayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .yml file is much more readable now!

@DanielDeLayo DanielDeLayo self-requested a review October 23, 2023 16:08
@DanielDeLayo DanielDeLayo dismissed their stale review October 23, 2023 16:08

github interface bad

@etwest etwest requested a review from DanielDeLayo November 26, 2023 21:31
Better, faster, stronger query algorithm for the refactor
@etwest etwest merged commit 75eb61c into main Dec 18, 2023
@etwest etwest deleted the refactor branch December 18, 2023 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setup for queries during multi-threaded stream is awkward Supernode and Sketch Configure

2 participants