-
Notifications
You must be signed in to change notification settings - Fork 5
Refactor Graph class -> GraphSketchDriver + CCSketchAlg #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielDeLayo
requested changes
Oct 19, 2023
We need to change the sketch interface. Let us input the vector length, instead of the square root of the vector length. |
DanielDeLayo
previously approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The .yml file is much more readable now!
This was
linked to
issues
Oct 31, 2023
DanielDeLayo
requested changes
Nov 8, 2023
DanielDeLayo
approved these changes
Dec 14, 2023
Better, faster, stronger query algorithm for the refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the key classes of this repository with the goal of increasing the flexibility of our code. We want to allow the possibly for writing code for other sketching algorithms on top of this repository. Specifically, we disentangled the setup for reading and processing graph streams from the code for running the connected components sketch algorithm. We also got rid of the Supernode class and refactored the sketch class to be more usable.
Also some other small stuff, see below.