-
Notifications
You must be signed in to change notification settings - Fork 419
Add functional tests for PropertiesFileTransformer
#1485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0b70c71
to
59008c5
Compare
59008c5
to
38f28d4
Compare
38f28d4
to
28b0c2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds functional tests for the PropertiesFileTransformer
, ensuring various merge strategies, key transformations, charset handling, mappings, and removal of the default timestamp header.
- Documented
CleanProperties
behavior with KDoc - Removed the generic
PropertiesFileTransformer
entry from the shared transformer matrix - Added a new
PropertiesFileTransformerTest
suite covering multiple scenarios
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/CleanProperties.kt | Added KDoc explaining suppression of the timestamp header |
src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/TransformersTest.kt | Removed the PropertiesFileTransformer case from the matrix |
src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/PropertiesFileTransformerTest.kt | Introduced functional tests for PropertiesFileTransformer |
Comments suppressed due to low confidence (2)
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/CleanProperties.kt:10
- [nitpick] The KDoc summary is a bit vague; consider clarifying that this class overrides
store
to suppress the default date comment header, for example: "CleanProperties overridesstore
to prevent writing the timestamp comment."
* Introduced in order to remove prepended timestamp when creating output stream.
src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/TransformersTest.kt:197
- Removing the PropertiesFileTransformer entry from the generic transformer matrix may leave its core behavior (especially
keyTransformer
logic) untested at that level; ensure these scenarios are fully covered by the new functional tests.
"" to ManifestResourceTransformer::class,
Refs