Skip to content

Conversation

@Goooler Goooler force-pushed the g/20250625/add-tests-for-prop-trans branch 2 times, most recently from 0b70c71 to 59008c5 Compare June 26, 2025 08:15
@Goooler Goooler force-pushed the g/20250625/add-tests-for-prop-trans branch from 59008c5 to 38f28d4 Compare June 30, 2025 10:55
@Goooler Goooler force-pushed the g/20250625/add-tests-for-prop-trans branch from 38f28d4 to 28b0c2b Compare June 30, 2025 12:10
@Goooler Goooler marked this pull request as ready for review June 30, 2025 12:19
@Goooler Goooler requested a review from Copilot June 30, 2025 12:21
Copilot

This comment was marked as outdated.

@Goooler Goooler requested a review from Copilot July 1, 2025 07:34
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds functional tests for the PropertiesFileTransformer, ensuring various merge strategies, key transformations, charset handling, mappings, and removal of the default timestamp header.

  • Documented CleanProperties behavior with KDoc
  • Removed the generic PropertiesFileTransformer entry from the shared transformer matrix
  • Added a new PropertiesFileTransformerTest suite covering multiple scenarios

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/CleanProperties.kt Added KDoc explaining suppression of the timestamp header
src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/TransformersTest.kt Removed the PropertiesFileTransformer case from the matrix
src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/PropertiesFileTransformerTest.kt Introduced functional tests for PropertiesFileTransformer
Comments suppressed due to low confidence (2)

src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/CleanProperties.kt:10

  • [nitpick] The KDoc summary is a bit vague; consider clarifying that this class overrides store to suppress the default date comment header, for example: "CleanProperties overrides store to prevent writing the timestamp comment."
 * Introduced in order to remove prepended timestamp when creating output stream.

src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/TransformersTest.kt:197

  • Removing the PropertiesFileTransformer entry from the generic transformer matrix may leave its core behavior (especially keyTransformer logic) untested at that level; ensure these scenarios are fully covered by the new functional tests.
      "" to ManifestResourceTransformer::class,

@Goooler Goooler enabled auto-merge (squash) July 1, 2025 07:39
@Goooler Goooler merged commit e2a9510 into main Jul 1, 2025
8 checks passed
@Goooler Goooler deleted the g/20250625/add-tests-for-prop-trans branch July 1, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant