Skip to content

fix: Helm deploy was not working with variable templatinging chart path #9600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 14, 2025
Merged

fix: Helm deploy was not working with variable templatinging chart path #9600

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
949566c
fix: Helm deployer was not working with variable templatingin chartPath
travishein Dec 7, 2024
2713447
fix: lint warnings.
travishein Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pkg/skaffold/deploy/helm/helm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,11 @@
return true, nil
}

if err := walk.From(release.ChartPath).When(isDep).AppendPaths(&deps); err != nil {
expanded_path, e := util.ExpandEnvTemplateOrFail(release.ChartPath, nil)

Check failure on line 401 in pkg/skaffold/deploy/helm/helm.go

View workflow job for this annotation

GitHub Actions / PR linters, checks 

ST1003: should not use underscores in Go names; var expanded_path should be expandedPath (stylecheck)
if e != nil {
return deps, helm.UserErr("issue expanding variable", e)
}
if err := walk.From(expanded_path).When(isDep).AppendPaths(&deps); err != nil {
return deps, helm.UserErr("issue walking releases", err)
}
}
Expand Down
Loading