Skip to content

chore: upgrade examples schema version #8746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ericzzzzzzz
Copy link
Contributor

@ericzzzzzzz ericzzzzzzz commented May 5, 2023

Description

  • upgrade skaffold.yaml schema version in example projects to unblock ci

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #8746 (bef32ab) into main (290280e) will decrease coverage by 6.05%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #8746      +/-   ##
==========================================
- Coverage   70.48%   64.43%   -6.05%     
==========================================
  Files         515      617     +102     
  Lines       23150    31171    +8021     
==========================================
+ Hits        16317    20085    +3768     
- Misses       5776     9585    +3809     
- Partials     1057     1501     +444     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 40 more

... and 406 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ericzzzzzzz ericzzzzzzz marked this pull request as ready for review May 5, 2023 15:11
@ericzzzzzzz ericzzzzzzz requested a review from a team as a code owner May 5, 2023 15:11
@ericzzzzzzz ericzzzzzzz requested a review from renzodavid9 May 5, 2023 15:11
@aaron-prindle
Copy link
Contributor

aaron-prindle commented May 5, 2023

I've created #8748 to resolve this. Technically examples/ is supposed to be mirrored from integration/examples which had some files added so the PR is missing some new examples/ that it should include

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants