Skip to content

fix: missing Sessionable ID in exported metrics #8737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gsquared94
Copy link
Contributor

This PR:

  • adds a sessionable ID (client_install_id) set to a random GUID
  • removes event fields not required or incorrectly set in current iteration

Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the quick fix here @gsquared94!

@aaron-prindle aaron-prindle added the kokoro:force-run forces a kokoro re-run on a PR label May 2, 2023
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label May 2, 2023
@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #8737 (b3770af) into main (290280e) will decrease coverage by 6.09%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #8737      +/-   ##
==========================================
- Coverage   70.48%   64.39%   -6.09%     
==========================================
  Files         515      617     +102     
  Lines       23150    31171    +8021     
==========================================
+ Hits        16317    20074    +3757     
- Misses       5776     9592    +3816     
- Partials     1057     1505     +448     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 40 more

... and 407 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gsquared94 gsquared94 added the kokoro:force-run forces a kokoro re-run on a PR label May 2, 2023
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label May 2, 2023
@aaron-prindle
Copy link
Contributor

Seems gcloud might have some breaking change it in, leading to kokoro failures. From the kokoro error logs:

ERROR: gcloud crashed (AttributeError): 'bool' object has no attribute 'lower'

Recent thread regarding this error:
https://stackoverflow.com/questions/76159439/job-failing-with-error-gcloud-crashed-attributeerror-bool-object-has-no-at

@gsquared94 gsquared94 merged commit 8f9209c into GoogleContainerTools:main May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants