fix: update skaffold verify to respect deploy default namespace field #8660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #8660 +/- ##
==========================================
- Coverage 70.48% 64.10% -6.39%
==========================================
Files 515 619 +104
Lines 23150 30945 +7795
==========================================
+ Hits 16317 19836 +3519
- Misses 5776 9618 +3842
- Partials 1057 1491 +434
... and 399 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
renzodavid9
reviewed
Apr 11, 2023
pkg/skaffold/runner/verifier.go
Outdated
Comment on lines
55
to
61
| var defaultDeployNS *string | ||
| if runCtx.DefaultPipeline().Deploy.KptDeploy != nil { | ||
| defaultDeployNS = runCtx.DefaultPipeline().Deploy.KptDeploy.DefaultNamespace | ||
| } | ||
| if runCtx.DefaultPipeline().Deploy.KubectlDeploy != nil { | ||
| defaultDeployNS = runCtx.DefaultPipeline().Deploy.KubectlDeploy.DefaultNamespace | ||
| } |
There was a problem hiding this comment.
I was thinking, does it make sense to use the runCtx.GetNamespace method here? I know we are not using the DefaultPipeline there, instead we are going through all the pipelines to calculate the namespace, but maybe is ok to have the same behaviour, what do you think?
There was a problem hiding this comment.
Yes, your suggestion is the better choice - changed now. I had forgotten we had refactored this to all be in one place 🎉!
renzodavid9
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8629