Skip to content

fix: create new docker network only when the --docker-network flag is not set #8649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

renzodavid9
Copy link
Contributor

Description
Change behaviour so we don't create a new docker network when skaffold verify is run with the --docker-network flag, instead we assume the docker network with the given name already exists.

@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #8649 (078c179) into main (290280e) will decrease coverage by 6.37%.
The diff coverage is 54.47%.

@@            Coverage Diff             @@
##             main    #8649      +/-   ##
==========================================
- Coverage   70.48%   64.12%   -6.37%     
==========================================
  Files         515      615     +100     
  Lines       23150    30817    +7667     
==========================================
+ Hits        16317    19761    +3444     
- Misses       5776     9572    +3796     
- Partials     1057     1484     +427     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 39 more

... and 395 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaron-prindle
Copy link
Contributor

Can you also update the flag help description here to indicate that this docker-network will not be created and what happens by default

https://github.com/GoogleContainerTools/skaffold/blob/main/cmd/skaffold/app/cmd/flags.go#L678

@renzodavid9
Copy link
Contributor Author

Can you also update the flag help description here to indicate that this docker-network will not be created and what happens by default

https://github.com/GoogleContainerTools/skaffold/blob/main/cmd/skaffold/app/cmd/flags.go#L678

Done! I changed the flag description.

Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@renzodavid9 renzodavid9 merged commit 97ee896 into GoogleContainerTools:main Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants