Skip to content

Conversation

@tejal29
Copy link
Contributor

@tejal29 tejal29 commented Nov 5, 2019

Relates to CI-CD health check docs.
Description
Give users more descriptive messge.

User facing changes

yes. Output lines changed. See below

Before
When Deployment did not stabilize, user will get an error message with

  1. Either kubectl rollout status command killed (as timoutContext was cancelled)
tejaldesai@@getting-started (add_healthcheck)$ ../../out/skaffold deploy --status-check
Tags used in deployment:
Starting deploy...
kubectl client version: 1.11+
kubectl version 1.12.0 or greater is recommended for use with Skaffold
 - deployment.apps/getting-started created
Waiting for deployments to stabilize
 - default:deployment/getting-started Waiting for rollout to finish: 0 of 1 updated replicas are available...
 - default:deployment/getting-started failed. Error: kubectl rollout status command killed.
FATA[0006] 1/1 deployment(s) failed             

Or
2. an error message. "context deadline exceeded`.

tejaldesai@@getting-started (add_healthcheck)$ ../../out/skaffold deploy --status-check
Tags used in deployment:
Starting deploy...
kubectl client version: 1.11+
kubectl version 1.12.0 or greater is recommended for use with Skaffold
 - deployment.apps/getting-started configured
Waiting for deployments to stabilize
 - default:deployment/getting-started Waiting for rollout to finish: 1 old replicas are pending termination...
 - default:deployment/getting-started failed. Error: context deadline exceeded.
FATA[0006] 1/1 deployment(s) failed                     

After
New message:

- default:deployment/getting-started failed. Error: received Ctrl-C or deployments could not stabilize within 5s: kubectl rollout status command interrupted.

e.g.


tejaldesai@@getting-started (add_healthcheck)$ ../../out/skaffold deploy --status-check
Tags used in deployment:
Starting deploy...
kubectl client version: 1.11+
kubectl version 1.12.0 or greater is recommended for use with Skaffold
 - deployment.apps/getting-started created
Waiting for deployments to stabilize
 - default:deployment/getting-started Waiting for rollout to finish: 0 of 1 updated replicas are available...
 - default:deployment/getting-started failed. Error: received Ctrl-C or deployments could not stabilize within 5s: kubectl rollout status command interrupted.
FATA[0006] 1/1 deployment(s) failed                     
tejaldesai@@getting-started (add_healthcheck)$

Next PRs.
none

Submitter Checklist

Reviewer Notes

  • The code flow looks good.
  • Unit test added.
  • User facing changes look good.

Release Notes

@tejal29 tejal29 added the priority/p0 Highest priority. We are actively looking at delivering it. label Nov 5, 2019
@tejal29 tejal29 mentioned this pull request Nov 5, 2019
@tejal29 tejal29 changed the title [docs] [output] meaningful message [docs] [output] meaningful message for healthcheck context exceeded. Nov 5, 2019
@codecov
Copy link

codecov bot commented Nov 5, 2019

Codecov Report

Merging #3177 into master will decrease coverage by 0.01%.
The diff coverage is 50%.

Impacted Files Coverage Δ
pkg/skaffold/deploy/resource/deployment.go 89.18% <0%> (-5.1%) ⬇️
pkg/skaffold/deploy/status_check.go 56.14% <100%> (+0.38%) ⬆️

@dgageot dgageot merged commit f31c3d0 into GoogleContainerTools:master Nov 6, 2019
@tejal29 tejal29 deleted the meanining_full_msg branch April 15, 2021 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes priority/p0 Highest priority. We are actively looking at delivering it. size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants