Skip to content

Conversation

@breun
Copy link
Contributor

@breun breun commented Mar 26, 2024

This PR contains Memorystore documentation improvements as described in #2735.

@breun breun force-pushed the memorystore-documentation-improvements branch from 23b8d3e to f43c84d Compare March 26, 2024 15:29
Copy link
Contributor

@zhumin8 zhumin8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time to update our documentation!
And sorry for the delay in review process.
I've tested out and this looks great in general, only got a few comments below.
btw, I see the linked codelab also has outdated configurations, I will update those.

Nils Breunese and others added 2 commits April 16, 2024 13:45
@breun
Copy link
Contributor Author

breun commented Apr 16, 2024

@zhumin8 Thanks for your suggestions, I've applied them all.

Copy link
Contributor

@zhumin8 zhumin8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed the fact that we use adoc instead of md formats, links in previous edits do not render correctly. Apologies for the extra work.

Otherwise this looks good to me. I will merge it in once these are updated.
Thanks again for contributing!

@breun
Copy link
Contributor Author

breun commented Apr 17, 2024

No problem, I've committed your suggested changes.

@zhumin8 zhumin8 changed the title Memorystore documentation improvements docs : Memorystore documentation improvements Apr 18, 2024
@zhumin8 zhumin8 changed the title docs : Memorystore documentation improvements docs: Memorystore documentation improvements Apr 18, 2024
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@zhumin8 zhumin8 merged commit b1e87b3 into GoogleCloudPlatform:main Apr 18, 2024
@breun breun deleted the memorystore-documentation-improvements branch April 18, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants