Skip to content

Conversation

@peter-zheng-g
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 28, 2019
@peter-zheng-g
Copy link
Contributor Author

The presubmit succeeded for php56, php70, and php71. It only failed for php72 due to some i/o timeout. Can some one please take a look?

@peter-zheng-g peter-zheng-g changed the title [CloudAsset] Update client library version to v1. [CloudAsset] Update client library version to use endpoint v1. Mar 29, 2019
@peter-zheng-g
Copy link
Contributor Author

Can someone please help trigger the Kokoro CI? The presubmit passed for php56, php70, and php71, and only failed for php72, and it didn't seem related to my change and likely temporary. Thanks.

@peter-zheng-g
Copy link
Contributor Author

peter-zheng-g commented Apr 1, 2019

Can someone please merge the pull request? Thanks!
BTW, it's already done for go (GoogleCloudPlatform/golang-samples#810) and dotnet (GoogleCloudPlatform/dotnet-docs-samples#778).

@bshaffer bshaffer merged commit bf3f4b8 into GoogleCloudPlatform:master Apr 3, 2019
@bshaffer
Copy link
Contributor

bshaffer commented Apr 3, 2019

Looks great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants