Skip to content

Conversation

gryczj
Copy link
Contributor

@gryczj gryczj commented Aug 19, 2024

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: compute Issues related to the Compute Engine API. labels Aug 19, 2024
@gryczj gryczj added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Aug 19, 2024
@gryczj gryczj force-pushed the compute-hyperdisk-pool-create branch from 8ee5382 to 6dc5ce4 Compare August 19, 2024 12:52
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 19, 2024
@gryczj gryczj force-pushed the compute-hyperdisk-pool-create branch 2 times, most recently from 09625c4 to f994413 Compare August 20, 2024 14:38
@gryczj gryczj marked this pull request as ready for review August 20, 2024 14:39
@gryczj gryczj requested review from a team as code owners August 20, 2024 14:39
Copy link

snippet-bot bot commented Aug 20, 2024

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@gryczj gryczj self-assigned this Aug 21, 2024
@gryczj gryczj force-pushed the compute-hyperdisk-pool-create branch 3 times, most recently from 87420a0 to 265ee7f Compare August 22, 2024 09:56
@gryczj

This comment was marked as resolved.

@gryczj gryczj force-pushed the compute-hyperdisk-pool-create branch 2 times, most recently from 2d24b83 to e837c97 Compare August 22, 2024 11:50
@gryczj gryczj force-pushed the compute-hyperdisk-pool-create branch from e837c97 to 220b38d Compare August 22, 2024 11:52
Copy link
Contributor

@subfuzion subfuzion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@subfuzion subfuzion mentioned this pull request Aug 22, 2024
1 task
@subfuzion subfuzion merged commit 4b58b83 into main Aug 22, 2024
32 checks passed
@subfuzion subfuzion deleted the compute-hyperdisk-pool-create branch August 22, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: compute Issues related to the Compute Engine API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants