Add activity journal feature for google_storage_insights_dataset_config

[sameer-google]

storageinsights: added `activityDataRetentionPeriodDays` fields to `google_storage_insights_dataset_config` resource

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 54 insertions(+))
google-beta provider: Diff ( 5 files changed, 54 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+))

[modular-magician]

Tests analytics

Total tests: 8
Passed tests: 6
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• storageinsights

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccStorageInsightsDatasetConfigExample_update_scope
• TestAccStorageInsightsDatasetConfig_storageInsightsDatasetConfigExcludesExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccStorageInsightsDatasetConfigExample_update_scope [Debug log]
TestAccStorageInsightsDatasetConfig_storageInsightsDatasetConfigExcludesExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[BBBmau]

tests passes but can you provide the link to the documentation that includes this new field? Unless the field has yet to be added

https://cloud.google.com/storage/docs/insights/reference/rest/v1/projects.locations.datasetConfigs

[sameer-google]

tests passes but can you provide the link to the documentation that includes this new field? Unless the field has yet to be added

https://cloud.google.com/storage/docs/insights/reference/rest/v1/projects.locations.datasetConfigs

The new field is added in the API, but the docs are not yet updated. Public docs are planned to update while the feature goes GA.

[zli82016]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 54 insertions(+))
google-beta provider: Diff ( 5 files changed, 54 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+))

[modular-magician]

Tests analytics

Total tests: 8
Passed tests: 8
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• storageinsights

🟢 All tests passed!

View the build log