Skip to content

Conversation

rajeshgupthar
Copy link
Contributor

@rajeshgupthar rajeshgupthar commented Sep 9, 2025

DO_NOT_SUBMIT

Updated provider dependencies for Certificate Manager

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


Mandatory reviewer - @aniket-gupta

@github-actions github-actions bot requested a review from c2thorn September 9, 2025 12:38
Copy link

github-actions bot commented Sep 9, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 3 insertions(+))
google-beta provider: Diff ( 2 files changed, 3 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 5544
Passed tests: 4913
Skipped tests: 601
Affected tests: 30

Click here to see the affected service packages

All service packages are affected

Action taken

Found 30 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager__service_perimeter_dry_run_egress_policy
  • TestAccContainerNodePool_EmptyGuestAccelerator
  • TestAccContainerNodePool_autoscaling
  • TestAccContainerNodePool_fastSocket
  • TestAccContainerNodePool_gcfsConfig
  • TestAccContainerNodePool_gvnic
  • TestAccContainerNodePool_privateRegistry
  • TestAccContainerNodePool_resize
  • TestAccContainerNodePool_resourceManagerTags
  • TestAccContainerNodePool_totalSize
  • TestAccContainerNodePool_version
  • TestAccContainerNodePool_withCgroupMode
  • TestAccContainerNodePool_withConfidentialNodes
  • TestAccContainerNodePool_withEnablePrivateNodesToggle
  • TestAccContainerNodePool_withHugepageConfig
  • TestAccContainerNodePool_withKubeletConfig
  • TestAccContainerNodePool_withLinuxNodeConfig
  • TestAccContainerNodePool_withLoggingVariantUpdates
  • TestAccContainerNodePool_withManagement
  • TestAccContainerNodePool_withMaxRunDuration
  • TestAccContainerNodePool_withNodeConfigWithBootDiskConfig
  • TestAccContainerNodePool_withTaintsUpdate
  • TestAccContainerNodePool_withUpgradeSettings
  • TestAccContainerNodePool_withWindowsNodeConfig
  • TestAccContainerNodePool_withWorkloadIdentityConfig
  • TestAccDataFusionInstance_dataFusionInstanceCmekExample
  • TestAccDialogflowEncryptionSpec_dialogflowEncryptionSpecBasicExample
  • TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample
  • TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample_update
  • TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager__access_level [Debug log]
TestAccAccessContextManager__access_level_condition [Debug log]
TestAccAccessContextManager__access_levels [Debug log]
TestAccAccessContextManager__access_policy [Debug log]
TestAccAccessContextManager__access_policy_scoped [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Debug log]
TestAccAccessContextManager__service_perimeter [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log]
TestAccAccessContextManager__service_perimeters [Debug log]
TestAccContainerNodePool_EmptyGuestAccelerator [Debug log]
TestAccContainerNodePool_autoscaling [Debug log]
TestAccContainerNodePool_gcfsConfig [Debug log]
TestAccContainerNodePool_gvnic [Debug log]
TestAccContainerNodePool_privateRegistry [Debug log]
TestAccContainerNodePool_resize [Debug log]
TestAccContainerNodePool_totalSize [Debug log]
TestAccContainerNodePool_version [Debug log]
TestAccContainerNodePool_withCgroupMode [Debug log]
TestAccContainerNodePool_withConfidentialNodes [Debug log]
TestAccContainerNodePool_withEnablePrivateNodesToggle [Debug log]
TestAccContainerNodePool_withHugepageConfig [Debug log]
TestAccContainerNodePool_withKubeletConfig [Debug log]
TestAccContainerNodePool_withLinuxNodeConfig [Debug log]
TestAccContainerNodePool_withLoggingVariantUpdates [Debug log]
TestAccContainerNodePool_withManagement [Debug log]
TestAccContainerNodePool_withMaxRunDuration [Debug log]
TestAccContainerNodePool_withNodeConfigWithBootDiskConfig [Debug log]
TestAccContainerNodePool_withTaintsUpdate [Debug log]
TestAccContainerNodePool_withUpgradeSettings [Debug log]
TestAccContainerNodePool_withWindowsNodeConfig [Debug log]
TestAccContainerNodePool_withWorkloadIdentityConfig [Debug log]
TestAccDataFusionInstance_dataFusionInstanceCmekExample [Debug log]
TestAccDialogflowEncryptionSpec_dialogflowEncryptionSpecBasicExample [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataFusionInstance_dataFusionInstanceCmekExample [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager__access_level_custom [Error message] [Debug log]
TestAccAccessContextManager__access_level_full [Error message] [Debug log]
TestAccAccessContextManager__gcp_user_access_binding [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_update [Error message] [Debug log]
TestAccContainerNodePool_fastSocket [Error message] [Debug log]
TestAccContainerNodePool_resourceManagerTags [Error message] [Debug log]
TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample [Error message] [Debug log]
TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample_update [Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this dependency update alone have any effect for users? Or is it just a prerequisite for a different change?

@SamanthaMathews
Copy link

does this dependency update alone have any effect for users? Or is it just a prerequisite for a different change?

This is a prerequisite for a different change

Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the changelog to no release note, as there is no impact to users.

Added the mandatory 2nd reviewer. I'll wait to LGTM as this says do not submit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants