-
Notifications
You must be signed in to change notification settings - Fork 2k
Add support for secure tags to (hierarchical) FirewallPolicyWithRules #14380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for secure tags to (hierarchical) FirewallPolicyWithRules #14380
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: For automatic test runs see go/terraform-auto-test-runs. @c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 1230 Click here to see the affected service packages
Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
Tests analyticsTotal tests: 1230 Click here to see the affected service packages
Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 1255 Click here to see the affected service packages
Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
mmv1/templates/terraform/examples/compute_firewall_policy_with_rules_full.tf.tmpl
Outdated
Show resolved
Hide resolved
Tests analyticsTotal tests: 1255 Click here to see the affected service packages
View the build log |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 1257 Click here to see the affected service packages
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
2871ccf
…GoogleCloudPlatform#14380) Co-authored-by: Luca Prete <[email protected]>
…GoogleCloudPlatform#14380) Co-authored-by: Luca Prete <[email protected]>
…GoogleCloudPlatform#14380) Co-authored-by: Luca Prete <[email protected]>
…GoogleCloudPlatform#14380) Co-authored-by: Luca Prete <[email protected]>
…GoogleCloudPlatform#14380) Co-authored-by: Luca Prete <[email protected]>
…GoogleCloudPlatform#14380) Co-authored-by: Luca Prete <[email protected]>
…GoogleCloudPlatform#14380) Co-authored-by: Luca Prete <[email protected]>
…GoogleCloudPlatform#14380) Co-authored-by: Luca Prete <[email protected]>
…GoogleCloudPlatform#14380) Co-authored-by: Luca Prete <[email protected]>
Adds support for secure tags in (hierarchical) FirewallPolicyWithRules.
Reference hashicorp/terraform-provider-google/issues/22859
Release Note Template for Downstream PRs (will be copied)