Skip to content

Add support for secure tags to (hierarchical) FirewallPolicyWithRules #14380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

LucaPrete
Copy link
Member

@LucaPrete LucaPrete commented Jun 26, 2025

Adds support for secure tags in (hierarchical) FirewallPolicyWithRules.

Reference hashicorp/terraform-provider-google/issues/22859

Release Note Template for Downstream PRs (will be copied)

compute: added `rule.match.src_secure_tags`, `rule.target_secure_tags`, `predefined_rules.match.src_secure_tags` and `predefined_rules.target_secure_tags` fields to `google_compute_firewall_policy_with_rules` resource

@github-actions github-actions bot requested a review from c2thorn June 26, 2025 16:48
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@zli82016 zli82016 requested review from zli82016 and removed request for c2thorn June 26, 2025 16:53
@zli82016
Copy link
Member

This PR is split from #14021. I will review this PR as I have reviewed the original PR #14021.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 662 insertions(+), 53 deletions(-))
google-beta provider: Diff ( 5 files changed, 662 insertions(+), 53 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 88 insertions(+))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 662 insertions(+), 53 deletions(-))
google-beta provider: Diff ( 5 files changed, 662 insertions(+), 53 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 88 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1230
Passed tests: 1145
Skipped tests: 83
Affected tests: 2

Click here to see the affected service packages
  • compute
#### Action taken
Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeFirewallPolicyWithRules_computeFirewallPolicyWithRulesFullExample
  • TestAccComputeFirewallPolicyWithRules_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyWithRules_computeFirewallPolicyWithRulesFullExample [Error message] [Debug log]
TestAccComputeFirewallPolicyWithRules_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1230
Passed tests: 1145
Skipped tests: 83
Affected tests: 2

Click here to see the affected service packages
  • compute
#### Action taken
Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeFirewallPolicyWithRules_computeFirewallPolicyWithRulesFullExample
  • TestAccComputeFirewallPolicyWithRules_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyWithRules_computeFirewallPolicyWithRulesFullExample [Error message] [Debug log]
TestAccComputeFirewallPolicyWithRules_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@LucaPrete
Copy link
Member Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 662 insertions(+), 53 deletions(-))
google-beta provider: Diff ( 5 files changed, 662 insertions(+), 53 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 88 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1255
Passed tests: 1167
Skipped tests: 86
Affected tests: 2

Click here to see the affected service packages
  • compute
#### Action taken
Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeFirewallPolicyWithRules_computeFirewallPolicyWithRulesFullExample
  • TestAccComputeFirewallPolicyWithRules_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeFirewallPolicyWithRules_computeFirewallPolicyWithRulesFullExample [Debug log]
TestAccComputeFirewallPolicyWithRules_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@zli82016
Copy link
Member

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 662 insertions(+), 53 deletions(-))
google-beta provider: Diff ( 5 files changed, 662 insertions(+), 53 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 88 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1255
Passed tests: 1169
Skipped tests: 86
Affected tests: 0

Click here to see the affected service packages
  • compute
🟢 All tests passed!

View the build log

@github-actions github-actions bot requested a review from zli82016 July 17, 2025 07:24
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 662 insertions(+), 53 deletions(-))
google-beta provider: Diff ( 5 files changed, 662 insertions(+), 53 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 88 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1257
Passed tests: 1170
Skipped tests: 86
Affected tests: 1

Click here to see the affected service packages
  • compute
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeFirewallPolicyWithRules_computeFirewallPolicyWithRulesFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeFirewallPolicyWithRules_computeFirewallPolicyWithRulesFullExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@zli82016 zli82016 added this pull request to the merge queue Jul 17, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 2871ccf Jul 17, 2025
27 checks passed
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 21, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 21, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants