This repository was archived by the owner on Oct 21, 2022. It is now read-only.
Implement the deprecated dependency finder #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liyanhui1228
changed the title
| package_name) | ||
| deprecated_deps = [] | ||
|
|
||
| for dep_name in dependency_info.keys(): |
There was a problem hiding this comment.
Maybe just "for dep_name in dependency_info:"
| "OutdatedDependency<'pip', HIGH_PRIORITY>", | ||
| "OutdatedDependency<'ply', HIGH_PRIORITY>") | ||
|
|
||
| self._store = mock.Mock() |
There was a problem hiding this comment.
Maybe it is better to pass in an autospec, otherwise it is possible that you have a typo in your method name, and the test still pass.
| finder = deprecated_dep_finder.DeprecatedDepFinder() | ||
|
|
||
| self.assertEqual(finder.py_version, '3') | ||
| self.assertTrue( |
There was a problem hiding this comment.
assertIsInstance is available after Python 3.2. I am not sure what Python versions should we support, but definitely use that if it is possible.
wangxf123456
approved these changes
Aug 29, 2018
ylil93
suggested changes
Aug 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #65
This PR also includes some refactoring of the existing code which moves some functions to common utils file.