This repository was archived by the owner on Oct 21, 2022. It is now read-only.
Use the latest version for the dependencies #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylil93
reviewed
Oct 11, 2018
|
|
||
| install_name = cs.packages[0].install_name | ||
| install_name_sanitized = install_name.split('[')[0] \ | ||
| if '[' in install_name else install_name |
Contributor
There was a problem hiding this comment.
if there is no '[' in the install_name, install_name.split('[') will return a list of size 1 containing install_name, so I think this line is redundant
ylil93
approved these changes
Oct 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In py3,
pip install apache-beamwill install 2.2.0 version; In py2, it will install 2.7.0.Changed to use the latest version for storing into the dependency info table.