core(legacy-javascript): update to target Baseline #16366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
reviewed
Mar 11, 2025
adamraine
reviewed
Mar 11, 2025
adamraine
reviewed
Mar 11, 2025
| for (const coreJsVersion of ['2.6.12', '3.40.0']) { | ||
| await waitForVariants(); | ||
|
|
||
| for (const coreJsVersion of ['3.40.0']) { |
There was a problem hiding this comment.
You're leaving this as a for loop in case we need to support more corejs versions in the future?
There was a problem hiding this comment.
Yeah, v4 is in the works.
adamraine
reviewed
Mar 11, 2025
| // Map, Set, WeakSet, etc. | ||
| // collection("Map", | ||
| // Currently not used. See create-polyfill-module-data.js | ||
| // expression += `|collection\\(${qt(property)},`; |
There was a problem hiding this comment.
Sorry I looked through create-polyfill-module-data.js but I still don't understand why this is unused
There was a problem hiding this comment.
done, is it clear now?
adamraine
approved these changes
Mar 12, 2025
This was referenced Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
esmodulesas the anchor for "legacy" JS, use Baselinecore-js-compat. This made it feasible to add many more polyfillsThis audit can now be described as: inform developers when they are polyfilling a feature that is widely supported across all major browsers, and provide an estimate for how much that costs (in terms of bytes / impact on metrics via byte efficiency).