Skip to content

Conversation

ngeissel
Copy link
Member

@ngeissel ngeissel commented May 6, 2025

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

This service is handling Nuki lock for Gladys Assistant (using MQTT and HTTP for now) : battery, lock state, lock / unlock action.
nuki_discovering_v1
nuki_interface_v1

See https://github.com/ngeissel/Gladys/tree/nuki/server/services/nuki#readme

@Pierre-Gilles
Copy link
Contributor

Hi @ngeissel 🙂 Just checking in, I’d love to merge this great PR!

Were you able to take a look at the changes we discussed last time?

@Pierre-Gilles
Copy link
Contributor

@ngeissel Thanks for the feedbacks, be careful you need to run Prettier on the front :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants