fix(components): Fix unknown prop onSort on DataTableHeaderCell #2783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying atlantis with
|
| Latest commit: |
2b909ad
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e14e166a.atlantis.pages.dev |
| Branch Preview URL: | https://job-139587-fix-unknown-on-so.atlantis.pages.dev |
jdeichert
reviewed
Oct 16, 2025
packages/components/src/DataTable/components/DataTableSortableHeader.tsx
Outdated
Show resolved
Hide resolved
jdeichert
reviewed
Oct 16, 2025
edison-cy-yang
deleted the
JOB-139587-fix-unknown-on-sort-property-on-data-table-sortable-header
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivations
There is a console error
Unknown event handler property onSort. It will be ignored.whenDataTableSortableHeaderis used. It is caused by spreading all the props ontoDataTableHeaderCell, in whichonSortdoesn't existChanges
Added
Changed
Deprecated
Removed
Fixed
onSort,direction, andchildrenprops ofDataTableSortableHeaderare not being passed intoDataTableHeaderCellSecurity
Testing
Load up storybook DataTable -> Web -> Composable -> Sortable and confirm the console error does not exist
Changes can be
tested via Pre-release
In Atlantis we use Github's built in pull request reviews.