add --window-title options with %M and %S variable replacement

[beango1]

solves issue #120
continuation of #573

[rom1v]

Thank you for your PR. It works 👍

However, I'm wondering if we shouldn't replace the variables on the server side instead:

• their value are device-specific values, known by the device;
• all variables are not always used (typically, they are not), so it's useless to transmit them all (more will be available in the future, see [Suggestion] Put user-friendly name of device in window name #601) just to ignore them on the client side;
• implementing a new variable would not require to modify the protocol between the server and the client;
• Java is much safer for string manipulation.

What do you think?

[beango1]

Fair points. Perhaps for next iterations. After doing all of the changes, I think it would have been cleaner just to set the window title the vanilla way. Let the user set the it the way they like ;)

…

On Fri., Jun. 21, 2019, 11:56 a.m. Romain Vimont, ***@***.***> wrote: Thank you for your PR. It works 👍 However, I'm wondering if we shouldn't replace the variables on the server side instead: - their value are device-specific values, known by the device; - all variables are not always used (typically, they are not), so it's useless to transmit them all (more will be available in the future, see #601 <#601>) just to ignore them on the client side; - implementing a new variable would not require to modify the protocol between the server and the client; - Java is much safer for string manipulation. What do you think? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#606?email_source=notifications&email_token=AFZMFPPJMWA7VZGEPBOHKILP3T23DA5CNFSM4HZO3WXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYI3NKA#issuecomment-504477352>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFZMFPOZG27PJWZAPLDUFS3P3T23DANCNFSM4HZO3WXA> .

[rom1v]

After doing all of the changes, I think it would have been cleaner just to set the window title the vanilla way.

A first separate commit doing just that would be great 😉

[beango1]

continued #614