3.3 Breaks --power-off-on-close function

[SaltireSoul]

Environment

• OS: Windows
• Scrcpy version: 3.3
• Installation method: scoop
• Device model: Pixel 8 Pro
• Android version: 14

Describe the bug

Version 3.3 of scrcpy breaks --power-off-on-close functionality, rolling back to 3.2 restores feature.

[rom1v]

Thank you very much for your report.

Fixed on dev by 4e1cf13.

Here is a server binary with the fix for scrcpy 3.3:

• scrcpy-server SHA-256: 4a5786ddb7b2572416fdd3e687daa762f4d0ebadd441f21c3dc1a78ee890ca2

technical details

bisect/bad is 283326b.

Here is the exception thrown from the cleanup process:

java.lang.AssertionError: java.lang.reflect.InvocationTargetException
    at com.genymobile.scrcpy.Workarounds.<clinit>(Workarounds.java:49)
    at com.genymobile.scrcpy.FakeContext.<init>(FakeContext.java:58)
    at com.genymobile.scrcpy.FakeContext.<clinit>(FakeContext.java:19)
    at com.genymobile.scrcpy.wrappers.InputManager.create(InputManager.java:32)
    at com.genymobile.scrcpy.wrappers.ServiceManager.getInputManager(ServiceManager.java:67)
    at com.genymobile.scrcpy.device.Device.injectEvent(Device.java:69)
    at com.genymobile.scrcpy.device.Device.injectKeyEvent(Device.java:76)
    at com.genymobile.scrcpy.device.Device.pressReleaseKeycode(Device.java:80)
    at com.genymobile.scrcpy.device.Device.powerOffScreen(Device.java:187)
    at com.genymobile.scrcpy.CleanUp.main(CleanUp.java:252)
    at com.android.internal.os.RuntimeInit.nativeFinishInit(Native Method)
    at com.android.internal.os.RuntimeInit.main(RuntimeInit.java:371)
Caused by: java.lang.reflect.InvocationTargetException
    at java.lang.reflect.Constructor.newInstance0(Native Method)
    at java.lang.reflect.Constructor.newInstance(Constructor.java:343)
    at com.genymobile.scrcpy.Workarounds.<clinit>(Workarounds.java:37)
    ... 11 more
Caused by: java.lang.RuntimeException: Can't create handler inside thread Thread[main,5,main] that has not called Looper.prepare()
    at android.os.Handler.<init>(Handler.java:231)
    at android.os.Handler.<init>(Handler.java:133)
    at android.app.ActivityThread$H.<init>(ActivityThread.java:2403)
    at android.app.ActivityThread.<init>(ActivityThread.java:404)
    ... 14 more