Skip to content

Upload artifacts showing diff images on test failure #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 27, 2020
Merged

Upload artifacts showing diff images on test failure #675

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5718fa6
Use GitHub Action to upload diff images on test failure
weiji14 Oct 27, 2020
fde0038
Set a unique artifact name for each OS/Python Version
weiji14 Oct 27, 2020
d3c5ba2
Temporarily trigger test_grdimage_shading_xarray to fail
weiji14 Oct 27, 2020
4dec78f
Add upload-artifact to GMT Latest tests
weiji14 Oct 27, 2020
0defa07
Revert changes to tests in test_grdimage that were disabled and fix typo
weiji14 Oct 27, 2020
7fbb777
Trigger fails on GMT master tests to double check artifacts are uploaded
weiji14 Oct 27, 2020
9527cf5
Revert "Trigger fails on GMT master tests to double check artifacts a…
weiji14 Oct 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/ci_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,14 @@ jobs:
shell: bash -l {0}
run: make test PYTEST_EXTRA="-r P"

# Upload diff images on test failure
- name: Upload diff images if any test fails
uses: actions/upload-artifact@v2
if: ${{ failure() }}
with:
name: artifact-${{ matrix.os }}-${{ matrix.python-version }}
path: tmp-test-dir-with-unique-name

# Build the documentation
- name: Build the documentation
shell: bash -l {0}
Expand Down
2 changes: 1 addition & 1 deletion pygmt/tests/test_grdimage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ def test_grdimage_central_meridians(grid, proj_type, lon0):
# are still slightly different with an RMS error of 25, see issue at
# https://github.com/GenericMappingTools/pygmt/issues/390
# TO-DO remove tol=1.5 and pytest.mark.xfail once bug is solved in upstream GMT
@check_figures_equal(tol=1.5)
# @check_figures_equal(tol=1.5)
@pytest.mark.parametrize("lat0", [0, 30])
@pytest.mark.parametrize("lon0", [0, 123, 180])
@pytest.mark.parametrize("proj_type", [pytest.param("Q", marks=pytest.mark.xfail), "S"])
Expand Down