Skip to content

Conversation

@seisman
Copy link
Member

@seisman seisman commented Oct 15, 2020

Description of proposed changes

This PR adds more tests for xarray grid shading.

Valid shading values are:

  • boolean
  • a constant intensity
  • some modifiers to automatically derive an intensity grid from input grid
  • an intensity grid with modifiers
  • an intensity grid in the (-1,+1) range

This PR covers the first 4 cases only. Of course, it only works for GMT>=6.2.0

Address #618.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

This PR adds more tests for xarray grid shading.

Valid `shading` values are:

- boolean
- a constant intensity
- some modifiers to automatically derive an intensity grid from input grid
- an intensity grid with modifiers
- an intensity grid in the (-1,+1) range

This PR covers the first 4 cases only.
@seisman seisman added the maintenance Boring but important stuff for the core devs label Oct 15, 2020
@seisman seisman added this to the 0.2.1 milestone Oct 15, 2020
@seisman seisman marked this pull request as draft October 15, 2020 20:44
@seisman seisman marked this pull request as ready for review October 15, 2020 20:44
@seisman seisman merged commit 0eab91f into master Oct 15, 2020
@seisman seisman deleted the tests/shading branch October 15, 2020 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants