Skip to content

Conversation

seisman
Copy link
Member

@seisman seisman commented Sep 14, 2020

Description of proposed changes

projection='M8i' sets the map width to 8 inch, not the figure width.
The figure with is larger than 8 inch, including frames and annotations.

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

projection='M8i' sets the map width to 8 inch, not the figure width.
The figure with is larger than 8 inch, including frames and annotations.
@seisman seisman added documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog labels Sep 14, 2020
@seisman seisman added this to the 0.2.x milestone Sep 14, 2020
@seisman seisman merged commit ae6bc9a into master Sep 14, 2020
@seisman seisman deleted the fix-typo branch September 14, 2020 01:53
@seisman seisman modified the milestones: 0.2.0, 0.2.1 Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants