Skip to content

Conversation

@seisman
Copy link
Member

@seisman seisman commented Jul 11, 2020

Add steps for "building documentation" and "uploading coverage to
codecov" in GitHub Actions.

We no longer need the Azure Pipelines jobs, except the one doing style checks.

Actually, I just found that the coverage were never successfully uploaded to codecov
in the Azure Pipelines jobs, due to the incorrect codecov token.

One more thing, codecov does't require a token for public repositories.

Add steps for "building documentation" and "uploading coverage to
codecov" in GitHub Actions.

We no longer need the Azure Pipelines jobs, except the one doing style
checks.
@vercel vercel bot temporarily deployed to Preview July 11, 2020 03:06 Inactive
@seisman seisman added the maintenance Boring but important stuff for the core devs label Jul 11, 2020
@seisman seisman added this to the 0.2.x milestone Jul 11, 2020
@seisman seisman changed the title Elimitae Azure Pipelines CI jobs, use GitHub Actions instead Eliminate Azure Pipelines CI jobs, use GitHub Actions instead Jul 11, 2020
@seisman seisman merged commit 1027b38 into master Jul 11, 2020
@seisman seisman deleted the remove-azure-pipelines branch July 11, 2020 03:50
@weiji14
Copy link
Member

weiji14 commented Jul 11, 2020

We no longer need the Azure Pipelines jobs, except the one doing style checks.

We can actually run the style checks on Github Actions too, but let's leave that for another day, we need a break from all the maintenance 😆.

Actually, I just found that the coverage were never successfully uploaded to codecov
in the Azure Pipelines jobs, due to the incorrect codecov token.

This doesn't surprise me, I noticed that the coverage reports all come from the Linux CIs on Travis. Good though that there's a Github Actions for codecov (is there nothing Github Actions can't do?)!

One more thing, codecov does't require a token for public repositories.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants