Skip to content

Conversation

@yvonnefroehlich
Copy link
Member

@yvonnefroehlich yvonnefroehlich commented Dec 16, 2025

@yvonnefroehlich yvonnefroehlich added this to the 0.18.0 milestone Dec 16, 2025
@yvonnefroehlich yvonnefroehlich self-assigned this Dec 16, 2025
@yvonnefroehlich yvonnefroehlich added the deprecation Deprecating a feature label Dec 16, 2025
@yvonnefroehlich yvonnefroehlich changed the title Deprecate parameter skiprows to skip_rows Deprecate parameter skiprows to skip_rows (Will be removed in v0.20.0) Dec 16, 2025
@seisman
Copy link
Member

seisman commented Dec 17, 2025

This is a common parameter. Do we really want to deprecate it?

@yvonnefroehlich
Copy link
Member Author

This is a common parameter. Do we really want to deprecate it?

Hm, skiprows is used in five functions, which is not optimal. "skip" and "rows" are short words, so readability should be OK without an underscore. So, probably better to keep it as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecation Deprecating a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants