Remove gmt from requirements.txt #257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@seisman I've been thinking about this a lot lately. Our current setup is very fragile. It's actually kind of broken with the hang ups in the conda packages (I still haven't been able to solve conda-forge/gmt-feedstock#57). I'll try to get this working on Travis with the conda packages. We'll just have to instruct people to compile GMT themselves. I'll include a build script for GMT that fetches the latest master and add it to the Makefile for easier updating and deploying. I'm a bit hesitant because GMT master is not very stable but it might be better than what we currently have. |
Member
Author
Member
|
👍 thanks! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Strictly speaking, gmt-python doesn't dependent on conda-forge's gmt, thus I propose to remove the gmt dependency from requirements.txt.
Also, such change makes it easy to test gmt-python with latest gmt master branch.