Skip to content

Conversation

@seisman
Copy link
Member

@seisman seisman commented Dec 31, 2022

Description of proposed changes

The setup.cfg file was removed in #1847 when we migrated configurations to pyproject.toml and was added back in #2109 for backward-compatibility with pip < 21.3.

The latest Anaconda/Miniconda now ships pip 22.2.2 by default, so it's time to remove the setup.cfg file again.

Closes #2100.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added the maintenance Boring but important stuff for the core devs label Dec 31, 2022
@seisman seisman added this to the 0.9.0 milestone Dec 31, 2022
@seisman seisman merged commit b1cc11b into main Dec 31, 2022
@seisman seisman deleted the remove-setup.cfg branch December 31, 2022 14:01
@seisman seisman added the skip-changelog Skip adding Pull Request to changelog label Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pip >=21.3 is required for editable install

3 participants