Skip to content

Allow Travis script to have existing build directory #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
seisman merged 1 commit into from
Jan 21, 2019
Merged

Allow Travis script to have existing build directory #328

seisman merged 1 commit into from
Jan 21, 2019

Conversation

@leouieda
Copy link
Member

@leouieda leouieda commented Jan 21, 2019

Travis allows caching of certain directories. For GMT/Python, we're
using the build script from this repo to build the latest GMT master
branch and test against it. But we cache the build directory to
speedup the build process (GenericMappingTools/pygmt#261).

Reminders

  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

@leouieda
Allow Travis script to have existing build directory
93a465c 
Travis allows caching of certain directories. For GMT/Python, we're
using the build script from this repo to build the latest GMT master
branch and test against it. But we cache the `build` directory to
speedup the build process (GenericMappingTools/pygmt#261).
@leouieda leouieda requested a review from a team January 21, 2019 15:52
@seisman seisman merged commit 398c916 into master Jan 21, 2019
@seisman seisman deleted the travis-build branch January 21, 2019 16:17
obaney pushed a commit to obaney/gmt that referenced this pull request Aug 18, 2021
@weiji14
Wrap grdview (GenericMappingTools#330)
088b0d1 
Wrapping the grdview function raised at GenericMappingTools#328, to be implemented under base_plotting.py. Original GMT `grdview` documentation can be found at https://docs.generic-mapping-tools.org/latest/grdview.html. Storing sample test cases under test_grdview.py.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seisman seisman seisman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@leouieda @seisman