Bring -l auto-legend to grdcontour and contour #1838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In response to #1826 I have added -l to grdcontour and pscontour. Works fine.
Member
|
If I use |
Member
Author
|
Yes, we should discuss this. It is a bit like plotting many symbols in plot at once. Perhaps -l can be repeatable, e.g. -l"Major contour"+s0.5c -l"Other contour"+s0.5c and then the first is annotated and second is non-annotated. Or we add a new +p modifier to set the pen we want directly. |
Member
Author
|
Since we want the -l option to make super easy and simple legends, we don't want to get bogged down in too complicated scenarios - for that there is the full legend syntax. It seems to me for contours we know that the simplest and most typical scenario is annotated contours and regular contours, using different pens by default. We know if both -C and -A were used or not. If only one was set then -l is straightforward and we use the pen that is used for those contours. If both are used (the more common case) then the user can given the -l option in one of three ways: The first will only add a single legend entry using the annotation pen, the third will add a single entry using the contour pen, while the middle entry will add two legend entries with the two separate pens and the two labels. This seems pretty simple and straight ward to me, versus introducing more modifiers etc. What you think? |
Member
Author
|
I should add I am not sure if it is really important to have two entries in the legend for annotated versus regular contours tough. Does it really add value to have two slightly different lines with labels "Main annotated contours" and "Other contours" that is not obvious from the map? Yet, the above solution would allow it,. |
PaulWessel
changed the title
Contributor
|
Agree, Paul. stay KISS. |
5 tasks
This makes the code easier to read.
Member
Author
|
I want to bring this issue to a conclusion. Here is my proposal: -lannotlabel : This will create a single legend entry using the annotation pen and this label. Thus, the most likely and default situation is we use the annotation pen to create a legend entry for the annotated contours. Would you agree with this, @joa-quim and @seisman? |
New test contourlegend.sh shows how to annotate both annotated and regular contours via -lannot/regular.
PaulWessel
changed the title
Member
Author
|
Not sure why the Windows build fails, @seisman, something about dependencies? |
Member
Author
|
BTW, I have completed the implementation of -l for the contour modules. Once can place either or both of the contour lines in the legend. I added a test. |
Member
|
-lannotlabel works but the other two don't work. Try: |
Member
Author
|
Hm, all those work fine for me - are you on the right branch @seisman ? |
Member
|
Yes, I'm using 6.1.0_e6bda85_2019.12.27. The second command gives me some warnings:
|
Member
Author
|
I am running 6.1.0_d5f689f_2019.12.28 I get no warnings and all three example plots perfectly. Even after a lengthy upgrade to Catalina on the home iMac... |
Member
Author
|
Take that back, I see those warnings and will look into them. But plots work... |
Member
Author
|
OK, that parsing of - is not gone. It was meant to indicate a default size of 0.5 cm but I forgot to skip a step. |
Member
Author
|
The WARNING about the legend height will be demoted to INFORMATION. It is a normal action. As for the central longitude - we never set that with -JM so not sure if this is a good warning either. |
Member
Author
|
Unrelated to this PR I have found that auto-legend placement in subplots are having some issues. Will make an issue soon. |
Member
|
I still got wrong legends for |
Member
Author
|
Strange. Can you do two things for me:
|
Member
|
gmt.legend: Debug message: |
Member
Author
|
See if this update helped, @seisman. |
seisman
approved these changes
Dec 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to #1826 I have added -l to grdcontour and pscontour. Works fine, e.g.,
gmt grdcontour @earth_relief_10m -R0/20/0/20 -JM6i -A1000 -C500 -B -Wc0.5p,red -lContour+h"LEGEND"+d -pdf mapI also clarified that this mechanism currently is limited to symbols and lines (but not polygons).