🐛 <Listbox> should scroll option into view only once #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
far-fetched
force-pushed
the
fix/listbox-scroll-option-into-view
branch
2 times, most recently
from
5546bfb to
19732aa
Compare
far-fetched
force-pushed
the
fix/listbox-scroll-option-into-view
branch
from
19732aa to
1bedfff
Compare
Collaborator
|
Looks solid 👊 Tested manually locally by mutating list of options and working well ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing test reference: click
fixes: #137
Issue:
In this repo, we vastly used the pattern "register children elements" in modifier. Then when in modifier callback, we use
this.args.*it will be reevaluated when thatargschanges <-- this is desired behavior.But because of this mechanism, we have to be very careful what functions are called inside modifier. This bug is caused by calling
this.scrollIntoViewmore than once. It affects the situation when user selects a new value (test) or new options are lazy loaded.Solution:
It turns out that we can scroll
listbox optioninto viewport not from root component, but delegate it to children (option). There is an only one moment when option should be scrolled (when is selected – what is being checked in constructor ofoption).Before:
Lazy loaded options with "jumpy" effect when promise resolved:
simplescreenrecorder-2022-12-16_08.03.25.mp4
After:
simplescreenrecorder-2022-12-16_08.07.05.mp4