Skip to content

Conversation

@NullVoxPopuli
Copy link
Collaborator

While working on this repo, I ran in to this error

.husky/pre-commit: 2: .: cannot open .husky/_/husky.sh: No such file

additionally, everyone should be setting:

npm config set ignore-scripts=true
yarn config set ignore-scripts true

because having any sort of post-install script active is a huge security risk -- and then disabling post-install scripts means husky won't work.

And since we want to ease effort-to-push, I think we should get rid of Husky.
If C.I. catching any issues, any maintainer can fix those.

@GavinJoyce
Copy link
Owner

I'm not familiar with husky, do you know what we were using it for?

@NullVoxPopuli
Copy link
Collaborator Author

it lints js, hbs, etc before commit, making it impossible to commit if there is a lint issue (unless you add --no-verify to your commit -- which I've had to do for every commit today because my local husky is broken, likely due to me having ignore-scripts)

@bertdeblock
Copy link
Contributor

You'll also want to remove the .husky folder and the lint-staged dependency. husky is only responsible for hooking into git. lint-staged is the one that executes the correct linters pre-commit for linting the staged files.

@NullVoxPopuli
Copy link
Collaborator Author

@bertdeblock thanks! done in last commit

@NullVoxPopuli NullVoxPopuli merged commit 125e684 into master May 30, 2022
@NullVoxPopuli NullVoxPopuli deleted the remove-husky branch May 30, 2022 16:30
@NullVoxPopuli NullVoxPopuli added the internal Internal changes that still require a mention in the changelog/release notes label Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Internal changes that still require a mention in the changelog/release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants