Enable skipped dialog tests again #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
One failing test, but seems unrelated. Will see if I can reproduce locally or does this one fail sometimes during CI? Didn't notice this when running the suite locally. |
Contributor
Author
|
@GavinJoyce Would you mind punching CI again? I can get the test to fail locally as well, but it only happens 1 out of 20 times or so. EDIT: Same tests passes over in #123. |
Owner
|
sure, they are running again now |
NullVoxPopuli
added
the
internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seemed like a good one to pick up. Surprisingly all tests, but one, ran fine for me locally.
I will try to have a look at the other skipped ones as well.
Related to #113.