Skip to content

[WIP] npm_sass_library #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matt-duch
Copy link

I didn't see any equivalent to npm_sass_library in this repo. I took a first pass at making a rule that covers it, and was curious if you'd want to explore this concept/merge something like this into your repo.

I'm using it to build a stylesheet that depends on "@carbon/styles", which is fairly complex, but I can't guarantee this logic is always correct (especially with nested npm dependencies).

@GZGavinZhao
Copy link
Owner

Hi! At a quick glance, I'm not opposed to having this merged and will take a closer look tomorrow. However, I'm curious on why would you want to use this instead of the official rules_sass, since the main purpose of creating this alternative ruleset is to get rid of the NodeJS dependency.

@GZGavinZhao GZGavinZhao marked this pull request as draft February 12, 2025 00:24
@sbarfurth
Copy link
Contributor

What's the suggestion today? It seems the canonical ruleset for JS is now rules_js by Aspect. I tend to agree that this doesn't need to provide a rule for integration, but it might be nice to show how one might integrate the two.

@Matt-Hurd
Copy link

Hi @sbarfurth, did you ever find a path forward here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants