This repository was archived by the owner on Nov 22, 2020. It is now read-only.
Changed logger implementation to be and actual api logger #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed logger implementation
Owner
|
Will handle the failed tests (which is some random fails) but looks good overall, thank you. This actually addressed with other contributor but looks this one have better approach so will go with this one |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you're making an api you shouldn't force your own logger and make users exclude it ect (would be weird if I need and exclude slf4j-simple for every dependency).
I also bumped kotlin and coroutines but can revert if you don't want that.
Don't mind the restclient stuff, I didn't know I had to use apply to set a custom one