Fixed attribute name when continuing a task #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR corrects the attribute name used when continuing a task by renaming the runtime configuration key in the README example.
- Renamed
continued_task_idtocontinued_job_idin the sampleruntime_config. - Ensures the example matches the updated API parameter.
Comments suppressed due to low confidence (2)
README.md:252
- Add or update a test case that validates the new
continued_job_idconfiguration to ensure the continuation logic is properly covered.
"runtime_config": {"continued_job_id": task_id},
README.md:252
- Consider updating other documentation or code examples that reference
continued_task_idto ensure consistency across the codebase.
"runtime_config": {"continued_job_id": task_id},
sidnarayanan
approved these changes
Jun 13, 2025
| @@ -249,7 +249,7 @@ task_id = client.create_task(task_data) | |||
| continued_task_data = { | |||
| "name": JobNames.CROW, | |||
| "query": "From the previous answer, specifically,how many species of crows are there?", | |||
| "runtime_config": {"continued_task_id": task_id}, | |||
| "runtime_config": {"continued_job_id": task_id}, | |||
There was a problem hiding this comment.
It occurs to me that continued_task_id is actually the more idiomatic name, but that's a bigger change.
There was a problem hiding this comment.
I agree. In our definitions, job is the agent+environment. When we invoke a job to run a query, we call it a task. But this needs to be changed somewhere else first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.