Smartparens strict mode backspacing over apostrophized words causes point jump

[dakrone]

Expected behavior

Let's assume I'm in the following org-mode buffer, | is the point:

* What happens if the ~target_response_rate~ is set too low?

Let's assume we r|

And I backspace up to the ', all good so far:

* What happens if the ~target_response_rate~ is set too low?

Let'|

If I hit backspace one more time, I expect:

* What happens if the ~target_response_rate~ is set too low?

Let|

Actual behavior

Instead, this is what I actually get:

* What happens if the ~target_response_rate|~ is set too low?

Let'

The cursor jumped up to the last surrounded thing!

Steps to reproduce the problem

Enable smartparens-strict-mode, attempt to duplicate the above buffer in org-mode

Environment & version information

• smartparens version: smartparens-20170430.844
• Active major-mode: org-mode
• Emacs version (M-x emacs-version): GNU Emacs 25.2.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.22.11) of 2017-04-25
• OS: Linux, Fedora 25

[Fuco1]

Well I'll be damned, you sure are right :D

I don't use strict mode in org (or other text modes) so I've never noticed. I think the parser thinks ' is a pair but it actually isn't and so the first pair it finds is the ~~ thing where it "skips over the delimiter".

This surely is a bug, thanks for the report!

[dakrone]

I don't use strict mode in org (or other text modes) so I've never noticed.

I use strict mode everywhere and I've noticed this in other modes than just org-mode, would you like reports of where else this bug happens when I come across them?

[Fuco1]

@dakrone Hm, sure, you can post the additional data here then. Thanks!

[dakrone]

Here's another example of smartparens-strict-mode misbehaving, this time in mu4e-message-mode

Buffer:

"Here'|s some text in quotes"

Pressing <backspace>:

"Here's some text in quotes|"

Cursor jumps to the end of the text instead of deleting the '

[jethrokuan]

My fix for this is to remove "'" as a pair. This is mostly lifted from @Fuco1 's configuration:

(sp-with-modes 'org-mode
         (sp-local-pair "'" nil :actions nil)
         ;; Other stuff here
)

Also, @Fuco1 the wiki for Pair Management seems to suggest that :rem is a valid input for :actions, but my emacs lisp interpreter disagrees.

[Fuco1]

@jethrokuan It should, if it doesn't work for you then please open a new issue with some detail (what form exactly you use etc.). Thanks!

[braham-snyder]

I believe this issue is a duplicate of #709

edit: though I suppose the current issue has additional info (that the bug also occurs with the apostrophe within the pair as opposed to after the pair, and the workaround that @jethrokuan noted of just removing ' as a pair), so not sure whether to close one

[dakrone]

if it doesn't work for you then please open a new issue with some detail (what form exactly you use etc.). Thanks!

Hmm.. that's too bad about having to remove ' as a pair though, I do still tend to quote things with ' and wrap existing things with it. Is there any way this could be solved without removing it as a pair?

[braham-snyder]

I don't believe he was offering that (removing the ' pair) as the resolution to the original issue--I think he was only asking for an additional bug report for this potential, tangential issue (which I haven't tested myself) mentioned by @jethrokuan :

Also, @Fuco1 the wiki for Pair Management seems to suggest that :rem is a valid input for :actions, but my emacs lisp interpreter disagrees.

[jethrokuan]

That was my solution to using strict-mode in org-mode anyway. There is no good way to determine when it should form a pair, and when it should simply be an apostrophe. An alternative solution is to only wrap when there's a space or word before, although this is probably a contrived solution:

(sp-pair "'" nil :unless '(sp-point-after-word-p))

[braham-snyder]

@jethrokuan I wasn't saying you didn't offer a workaround for the original issue. I was referring to the fact that @Fuco1 still considers the original issue an unresolved bug, and that he (@Fuco1) was merely asking for you (@jethrokuan) to file a new, separate issue for this tangential problem you're saying you encountered:

Also, @Fuco1 the wiki for Pair Management seems to suggest that :rem is a valid input for :actions, but my emacs lisp interpreter disagrees.

There is no good way to determine when it should form a pair, and when it should simply be an apostrophe. An alternative solution is to only wrap when there's a space or word before, although this is probably a contrived solution:

unless I'm misunderstanding you, you might want to take a look at sp-navigate-use-textmode-stringlike-parser (which addresses what I believe you're describing)