Request: activate smartparens in minibuffer

[tkf]

Why is smartparens turned off in minibuffer? It is useful, for example when writing sexp or shell command in minibuffer.

[Fuco1]

Hm, I don't really know. I think there was a problem with smex/ido, at least in the early stages. I'll re-enable it for myself and test it for a while.

You can enable it by editing this funciton

;;;###autoload
(defun turn-on-smartparens-mode ()
  "Turn on `smartparens-mode'."
  (interactive)
  (unless (or (member major-mode sp-ignore-modes-list)
              (minibufferp))
    (smartparens-mode t)))

[tkf]

Don't you need this too?:

(setq sp-ignore-modes-list
      (delete 'minibuffer-inactive-mode sp-ignore-modes-list))

[Fuco1]

I don't think you do. In fact, I should probably just remove that mode from the list completely since it is an inactive mode and so you can't be doing editing in it. That was added on my 2nd day with elisp, so I had no idea what I was doing :)

[Fuco1]

Aha, now I see why I disabled it. It's because ' will pair there, and I don't know what is the minibuffer mode called (if it is called anything at all). So you can't add local permissions for minibuffer, and adding a special hack seems a bit meh, for the relatively short code you write in there (using M-: I presume).

If you know what mode is used in minubuffer or how to detect it in a way that would play nicely with (member major-mode (list of modes where feature is disabled)) let me know.

[tkf]

Hmm... Strange. It does not work without removing minibuffer-inactive-mode from sp-ignore-modes-list in my environment. Also, it looks like minibuffer-inactive-mode is the mode even if I can edit the minibuffer. Here is how I checked:A

1. M-: (run-with-idle-timer 1 nil (lambda () (message "%S" major-mode)))
2. Then quickly type M-: again, to go into minibuffer.

I don't understand what do you mean by ' will pair there. What's wrong with that? Also, I think you don't need a special hack because user can use minibufferp in sp-autoinsert-inhibit-functions.

I think the problem is the long message coming sp-get-sexp. It works fine if I disallow it. Here is my setting:

(setq sp-ignore-modes-list
      (delete 'minibuffer-inactive-mode sp-ignore-modes-list))

(defadvice turn-on-smartparens-mode
  (around my-turn-on-smartparens-mode activate)
  "Advice `turn-on-smartparens-mode' to use smartparens in minibuffer."
  (unless (member major-mode sp-ignore-modes-list)
    (smartparens-mode t)))

(defadvice turn-on-show-smartparens-mode
  (around my-turn-on-show-smartparens-mode activate)
  "Advice `turn-on-show-smartparens-mode' to use smartparens in minibuffer."
  (unless (member major-mode sp-ignore-modes-list)
    (show-smartparens-mode t)))

(defadvice sp-get-sexp (around my-sp-get-sexp activate)
  "Advice `sp-get-sexp' to use smartparens in minibuffer."
  (let ((message-1 (symbol-function 'message)))
    (flet ((message (args)
                    (unless (minibufferp)
                      (apply message-1 args))))
      ad-do-it)))

[Fuco1]

I mean that when I do M-: and type (set 'bla) the result is (set 'bla'), and since there's no mode associated with minibuffer (or so I thought) you can't disable that.

I'll try to mess around with minibuffer-inactive-mode a bit more.

Also, that last advice seems like a good idea to implement in the core, I'll add that as well :) Thanks for doing the research.

[tkf]

You can locally ban ' in minibuffer-inactive-mode, right? Then I see no problem.

You might want paring for ' in M-! but it is still useful (e.g., you get paring for ").

[Fuco1]

Yes you can, provided that minibuffer-inactive-mode is active mode during editing. You're telling me it is, so then there's no problem :p

Yea, it might be useful for shell commands, but definitely annoying in M-:. So I'll remove the minibufferp check but keep the minibuffer-inactive-mode in the disabled modes by default.

Probably, we can advise whatever function M-: runs to disable paring of ' just during that editing time, so it works in shell (where you write 'literals' with quotes), and is turned off during lisp editing.

You can also take a look at [Issue #31] where we discuss new configuration interface. I guess that we could find a neat way to represent this constraint there, e.g. add another field where you can disable the pairs during command's execution (or something like that... I'm not entirely sure how these shell/sexp minubuffer things work)

[tkf]

Yea, I think supporting minibuffer for different command appropriately is possible. For example, you can define advice like this as you said:

(defadvice eval-expression (around sp-eval-expression activate)
  (let ((sp--major-mode 'emacs-lisp-mode))
    ad-do-it))

and use (or sp--major-mode major-mode) instead of major-mode everywhere in smartparens.el. But defining all advices is cumbersome...

Anyway removing minibufferp is quite nice first step :)

I wanted to follow #31 but it's bit long. Perhaps I will have a look later.

[tkf]

With the fixes in #43 and #44, I am using smartparens happily in minibuffer for a while now.

[Fuco1]

Good, I've merged your changes in. Thanks!

[purcell]

@tkf Can you share the settings you're using for smartparens in the minibuffer? Using the default config I'm not getting any pair-matching in the minibuffer:

(setq sp-base-key-bindings 'paredit)
(smartparens-global-mode t)
(show-smartparens-global-mode t)
(require 'smartparens-config)

[tkf]

@purcell I have this in my config:

(setq sp-ignore-modes-list
      (delete 'minibuffer-inactive-mode sp-ignore-modes-list))