i2svg options should be optional #14512
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In i2svg, when specifying the 'node' param, typescript then requires the 'callback' param. Both 'node' and 'param' should be optional.
|
@mlwilkerson could you please take a look here? |
|
Thanks @cooljeffro and @tagliala . This looks good to me and seems to bring the intended use of I'll pass it along for possible inclusion in a future release of |
| @@ -101,7 +101,7 @@ export interface IconParams extends Params { | |||
| mask?: IconLookup; | |||
| } | |||
| export interface DOM { | |||
| i2svg(params?: { node: Node; callback: () => void }): Promise<void>; | |||
| i2svg(params?: { node?: Node; callback?: () => void }): Promise<void>; | |||
| css(): string; | |||
| insertCss(): string; | |||
| @@ -101,7 +101,7 @@ export interface IconParams extends Params { | |||
| mask?: IconLookup; | |||
| } | |||
| export interface DOM { | |||
| i2svg(params?: { node: Node; callback: () => void }): Promise<void>; | |||
| i2svg(params?: { node?: Node; callback?: () => void }): Promise<void>; | |||
| css(): string; | |||
| insertCss(): string; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In i2svg, when specifying the 'node' param, typescript then requires the 'callback' param. Both 'node' and 'callback' should be optional.
I understand that:
I understand that it will not be merged and I will not be listed as a contributor on this project.