Make ModelState Error Prefix Optional #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @RehanSaeed I believe making parameters optional is actually a binary breaking change so this isn't something I'll be able to merge without a major version release. Can you switch this to be a separate overload instead? We can then switch it to an optional parameter on the next major release. Edit: I misremembered - it's adding a new optional parameter that's problematic, but this is an existing parameter so should be fine. I'll aim to merge later this week. |
|
Makes sense, I wasn't sure how amenable you'd be to a breaking change. Added an overload now. This may also be slightly better for performance since there is no null or empty check. |
|
thanks! |
|
I've pushed out 11.2.2 with this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.