Skip to content

Localization #1657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 7, 2025
Merged

Localization #1657

merged 15 commits into from
May 7, 2025

Conversation

cgjgh
Copy link
Contributor

@cgjgh cgjgh commented Apr 2, 2025

Description

Adding localization to all nodes...

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@cgjgh
Copy link
Contributor Author

cgjgh commented Apr 2, 2025

Hi @joepavitt,

I could use your expertise on something on this.
We’re dealing with a lot of repeated localization values in the project. Would it be feasible to consolidate these using a shared JSON file for common localization values?

Also, if you have a moment, I'd appreciate it if you could review the work so far to ensure I'm adhering to standards and best practices.

Thanks in advance for your help—I truly appreciate it!

@joepavitt
Copy link
Collaborator

I should get a chance to take a look on Friday. Thanks for the contributions!

@cgjgh cgjgh marked this pull request as ready for review April 23, 2025 17:46
Copy link
Collaborator

@joepavitt joepavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @cgjgh

@joepavitt joepavitt merged commit 813136d into FlowFuse:main May 7, 2025
1 of 2 checks passed
@Steve-Mcl Steve-Mcl mentioned this pull request Jul 12, 2025
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants