-
Notifications
You must be signed in to change notification settings - Fork 56
Update mermaid and dompurify #1656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested locally, including running the E2E tests which are failing in GH atm. |
joepavitt
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An issue with
dompurify
in versions < 3.2.4 means we need to update mermaid to the 11.x streamCurrently, our dep version of mermaid is on the 10.x stream and latest 10.x version on npm specifies
"dompurify": "^3.0.5 <3.1.7"
Since the affected versions of dompurify are
< 3.2.4
and the mermaid v10.x dep version of dompurify is oddly specific, I suggest we bite the bullet on mermaid & update it to 11.x streamNOTE:
The largest build artifact after bumping mermaid 10.x > 11.x breached the existing
maximumFileSizeToCacheInBytes
limit of3000000
causing an excception during build...BEFORE:
../dist/assets/index-u2-eCxOI.js 2,894.88 kB │ gzip: 874.95 kB
AFTER:
../dist/assets/index-DjK0W9yJ.js 3,253.47 kB │ gzip: 948.45 kB
(This is likely due to new mermaid and updated dompurify)
Related Issue(s)
https://github.com/FlowFuse/node-red-dashboard/security/dependabot/52
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
area:migration
label