Border alignment for antialiasing

[bertini97]

Hi. Based on the fact that #69 was discarded in favour of #70 because of the non-antialiasing, I made very slight changes to make the lines align better to the pixels and not have 2px transparent borders. I found this trick here.

Here are some results (with red border in the light scene to enhance the comparison). Left is unpatched.

Sorry If I'm this pedantic, but Qt 6.8 introduced this as default on GNOME, and the transparent border is an eye sore, and really noticeable when the window is tiled left or right, because you can then see your background.

Cheers

[grulja]

Please, squash all the commits into one once you are ready and fix clang-format check. I will try to look into it as soon as possible. Also, what about pushing this to Qt upstream? It looks even the previous change I did (#70) is not there. Maybe that will fix your issue? Or is that change not enough.

[grulja]

I tested this patch on top of QtWayland and it seems to work really well after initial testing. I just had to fix the border at the bottom (see code suggestion).

[bertini97]

I'm sorry, squashing the commits deleted your code suggestion 😅. I'll resquash after. Sorry again

[grulja]

I'm sorry, squashing the commits deleted your code suggestion 😅. I'll resquash after. Sorry again

No, I actually forgot to submit it. Can you please also update your commit message? Using final commit will be weird in the history. Also a describing what this change is about in the commit message also helps.

[bertini97]

Done. Sorry for the naming, I assumed the commits woudn't appear in the final tree.

[grulja]

There is still one formatting issue there with the one I suggested. Can you please fix that? Does my suggestion work for you? It has fixed the border at the bottom for me.

[bertini97]

There is still one formatting issue there with the one I suggested. Can you please fix that? Does my suggestion work for you? It has fixed the border at the bottom for me.

Yes, it works. Thank you. Should be properly formatted now.

[bertini97]

Also, what about pushing this to Qt upstream? It looks even the previous change I did (#70) is not there. Maybe that will fix your issue? Or is that change not enough.

I thought they were pulling from this repo directly. In any case, it's enough if it lands in qadwaitadecorations, the next version of Qt6 hopefully picks it up.

[grulja]

Also, what about pushing this to Qt upstream? It looks even the previous change I did (#70) is not there. Maybe that will fix your issue? Or is that change not enough.

I thought they were pulling from this repo directly. In any case, it's enough if it lands in qadwaitadecorations, the next version of Qt6 hopefully picks it up.

No, I implemented the decoration in QtWayland myself. I can backport the other change and this one if you allow me to, of course mentioning you as the author.

[bertini97]

No, I implemented the decoration in QtWayland myself. I can backport the other change and this one if you allow me to, of course mentioning you as the author.

Feel free, don't worry about crediting. However, please consider a unification, because Qt's upstream decorations share the same name as these, but are missing shadows which are a major usability improvement. Users might be confused as to why they have the "adwaita decorations" but missing some functionality.

[grulja]

No, I implemented the decoration in QtWayland myself. I can backport the other change and this one if you allow me to, of course mentioning you as the author.

Feel free, don't worry about crediting. However, please consider a unification, because Qt's upstream decorations share the same name as these, but are missing shadows which are a major usability improvement. Users might be confused as to why they have the "adwaita decorations" but missing some functionality.

I might backport shadows there too, even though the implementation here is not perfect.

[grulja]

Qt change: https://codereview.qt-project.org/c/qt/qtwayland/+/603925