Skip to content

Conversation

grulja
Copy link
Contributor

@grulja grulja commented Mar 18, 2024

Fixes #60

@grulja
Copy link
Contributor Author

grulja commented Mar 18, 2024

@TheBoctor can you please test? :)

@grulja grulja force-pushed the pressed-state branch 3 times, most recently from 3a67e5b to ea43a79 Compare March 18, 2024 10:20
@TheBoctor
Copy link

image
image
The colors all appear consistent with the screenshots in #60, and the pressed state mostly works as expected.

However, if the user clicks and drags outside of a button to trigger maximization, as described in #58, any further left clicks inside the Qt app window will cause the last pressed button to assume the pressed color. This persists until one of the buttons is clicked and released, without the cursor leaving its area.

@grulja
Copy link
Contributor Author

grulja commented Mar 18, 2024

However, if the user clicks and drags outside of a button to trigger maximization, as described in #58, any further left clicks inside the Qt app window will cause the last pressed button to assume the pressed color. This persists until one of the buttons is clicked and released, without the cursor leaving its area.

What about now?

@TheBoctor
Copy link

Looks good now. The pressed color changes back to normal as expected, as soon as the user interacts with the window.

@grulja
Copy link
Contributor Author

grulja commented Mar 18, 2024

Looks good now. The pressed color changes back to normal as expected, as soon as the user interacts with the window.

Thanks for testing. I tested it myself before, it's not like I'm blindly pushing changes, but I wanted someone to double-check and I'm glad I did that, because you spotted an issue.

@grulja grulja merged commit 8aaeb33 into main Mar 18, 2024
@grulja grulja deleted the pressed-state branch March 18, 2024 15:53
@TheBoctor
Copy link

Looks good now. The pressed color changes back to normal as expected, as soon as the user interacts with the window.

Thanks for testing. I tested it myself before, it's not like I'm blindly pushing changes, but I wanted someone to double-check and I'm glad I did that, because you spotted an issue.

No worries. I assumed you were also checking everything, but an extra set of eyes never hurts. Thanks for fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing "pressed" state for window buttons
2 participants